Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subnet: update status after deleting IP CR #3113

Closed
wants to merge 2 commits into from

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Aug 4, 2023

What type of this PR

  • Bug fixes
  • Tests

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at f9a4ee3

This pull request enhances the garbage collection and status update of logical switch ports and IP custom resources in the kube-ovn controller. It also adds a new e2e test case to verify the subnet status updates in the underlay network.

🤖 Generated by Copilot at f9a4ee3

We're sailing on the kube-ovn net, oh aye, oh aye
We're cleaning up the ports and IPs, oh aye, oh aye
We're using subnet as a key, to update the status easily
And we're testing it with IPv6, oh aye, oh aye

HOW

🤖 Generated by Copilot at f9a4ee3

  • Add a new variable subnet to store the subnet name of the lsp in markAndCleanLSP and query the IP CR to get the subnet name (link, link)
  • Enqueue the subnet name to the updateSubnetStatusQueue after marking and cleaning the lsp, deleting the IP CR, or releasing the address for the port (link, link, link)
  • Simplify the code in syncKubeOvnNet by assigning the subnet object to a variable (link)
  • Add a new function waitSubnetStatusUpdate to the underlay package to wait for the subnet status fields to match the expected values (link)
  • Call the waitSubnetStatusUpdate function in the TestUnderlayIPAM test case to verify the subnet status updates after creating and deleting pods with different subnets and IP versions (link, link, link, link, link, link, link, link, link)

@zhangzujian zhangzujian added bug Something isn't working test automation tests need backport labels Aug 4, 2023
@zhangzujian zhangzujian marked this pull request as ready for review August 4, 2023 03:40
@zhangzujian zhangzujian marked this pull request as draft August 4, 2023 09:43
@zhangzujian zhangzujian closed this Aug 5, 2023
@zhangzujian zhangzujian deleted the fix-subnet branch August 5, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants