Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: fix vpc update #3117

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Aug 5, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

  1. fixes reference to nil pointer;
  2. fixes modification of cached object;
  3. remove logging without detailed information.

WHAT

🤖 Generated by Copilot at 1c16c27

Refactored some controller code to use deep copies and improve readability. Removed redundant log statements. Added more error details for ovn-sbctl command.

🤖 Generated by Copilot at 1c16c27

Sing, O Muse, of the mighty pull request
That the skilled developer wrought with care
To enhance the code of the subnet.go file
And fix the errors that lurked in there.

HOW

🤖 Generated by Copilot at 1c16c27

  • Rename vpc to cachedVpc and create deep copies of the cached object before updating it in pkg/controller/subnet.go (link, link, link)
  • Remove unused or redundant variables and log statements in pkg/controller/subnet.go and pkg/controller/vpc.go (link, link, link, link)
  • Rename vpc to status and create a deep copy of the cached object's status before updating it in pkg/controller/vpc.go (link)
  • Remove redundant log statements in pkg/ovs/ovn-nb-logical_router_route.go (link)
  • Add command output to error log in pkg/pinger/ovn.go (link)

@zhangzujian zhangzujian added the bug Something isn't working label Aug 5, 2023
@zhangzujian zhangzujian marked this pull request as ready for review August 5, 2023 05:26
@zhangzujian zhangzujian merged commit d8fa839 into kubeovn:master Aug 7, 2023
59 checks passed
@zhangzujian zhangzujian deleted the fix-vpc branch August 7, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants