sbctl chassis operation replace with libovsdb #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zhangzujian
reviewed
Aug 11, 2023
zhangzujian
reviewed
Aug 11, 2023
zhangzujian
reviewed
Aug 11, 2023
zhangzujian
reviewed
Aug 11, 2023
Co-authored-by: 张祖建 <[email protected]>
|
Which version of the ovn sb schema did you use to generate the Model types? |
zhangzujian
reviewed
Aug 11, 2023
|
|
the version is kube-ovn master is using now. i export the schema from kube-ovn-cni pod |
已移除 sb 在 NewLegacyClient 中的字段 |
zhangzujian
reviewed
Aug 15, 2023
zhangzujian
reviewed
Aug 15, 2023
zhangzujian
reviewed
Aug 15, 2023
Signed-off-by: bobz965 <[email protected]>
zhangzujian
reviewed
Aug 17, 2023
Co-authored-by: 张祖建 <[email protected]>
zhangzujian
reviewed
Aug 17, 2023
|
These fields defined in struct ClusterRouter string
ClusterTcpLoadBalancer string
ClusterUdpLoadBalancer string
ClusterTcpSessionLoadBalancer string
ClusterUdpSessionLoadBalancer string
NodeSwitch string
NodeSwitchCIDR string
Version string |
Signed-off-by: bobz965 <[email protected]>
zhangzujian
approved these changes
Aug 17, 2023
bobz965
added a commit
that referenced
this pull request
Aug 17, 2023
* add ovnsb mod * ovn 层名统一复用用底层 ovs client 命名 * kube-ovn-controller 需要使用 sb nb client, 所以调整命名 * replace sbctl operate chassis Signed-off-by: bobz965 <[email protected]> Co-authored-by: 张祖建 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Features
sbctl need replaced with libovsdb #3106
基于 kube-ovn 目前在用 ovn 导出 sb shcema 并生成 sb db model
将 sbctl 替换为 libovsdb 来操作 chassis
去除 之前用于sbctl 过滤用的 external ids 冗余 node tag
简化一些判断冲突 chassis 清理的逻辑
kube-ovn-controller 区分 nbclient 以及 sb client
WHAT
🤖 Generated by Copilot at ad1dfb0
No summary available (Limit exceeded: required to process 73498 tokens, but only 50000 are allowed per call)
🤖 Generated by Copilot at 2d5e395
HOW
🤖 Generated by Copilot at ad1dfb0
No walkthrough available (Limit exceeded: required to process 73498 tokens, but only 50000 are allowed per call)