Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ovn nat not clean #3139

Merged
merged 4 commits into from
Aug 16, 2023
Merged

fix ovn nat not clean #3139

merged 4 commits into from
Aug 16, 2023

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Aug 14, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 3b5d53e

This pull request refactors and improves the controller code for handling ovn dnat, fip, and snat events. It removes unnecessary code, reduces logging verbosity, and optimizes performance by avoiding extra lookups. It also makes the logging messages more consistent and visible across the different files.

🤖 Generated by Copilot at 3b5d53e

We're haulin' on the ropes of the ovn code
We're makin' it more simple and more fast
We're loggin' and we're handlin' the dnat and the snat
We're workin' as a team to raise the mast

HOW

🤖 Generated by Copilot at 3b5d53e

  • Simplify and refactor the code that handles deletion events for ovn dnat, fip, and snat rules, by passing the object instead of the key and removing unnecessary checks and error handling (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Change the logging level of several messages from 3 to the default level, to make them more visible and consistent with other similar messages in ovn_dnat.go, ovn_fip.go, and ovn_snat.go (link, link, link, link, link, link, link, link, link, link, link)

@bobz965 bobz965 force-pushed the fix-fip-not-clean branch 2 times, most recently from 73d8fe2 to fbbd75e Compare August 15, 2023 05:48
@bobz965 bobz965 merged commit 2f6f675 into kubeovn:master Aug 16, 2023
58 checks passed
@bobz965 bobz965 deleted the fix-fip-not-clean branch August 16, 2023 05:37
bobz965 added a commit that referenced this pull request Aug 16, 2023
* fix ovn nat not clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants