underlay: fix NetworkManager operation #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
reviewed
Aug 22, 2023
Signed-off-by: 张祖建 <[email protected]>
Signed-off-by: 张祖建 <[email protected]>
Signed-off-by: 张祖建 <[email protected]>
oilbeater
approved these changes
Aug 23, 2023
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Aug 23, 2023
* underlay: fix NetworkManager operation * underlay: clear address lifetime --------- Signed-off-by: 张祖建 <[email protected]>
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Aug 23, 2023
* underlay: fix NetworkManager operation * underlay: clear address lifetime --------- Signed-off-by: 张祖建 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 32250b4
This pull request updates the
golang.org/x/modmodule, improves the NetworkManager integration and device management in the daemon package, and fixes a connectivity issue when switching devices inovs_linux.go.🤖 Generated by Copilot at 32250b4
HOW
🤖 Generated by Copilot at 32250b4
pkg/daemon/nm_linux.goto compare NetworkManager versions (link)pkg/daemon/nm_linux.goto improve logic of checking vlan and DNS settings, and add special case for NetworkManager v1.18.x bug (link)pkg/daemon/ovs_linux.goto prevent expiration when switching devices (link)