add golang lint #3154
Merged
add golang lint #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changluyi
force-pushed
the
add_golang_lint
branch
from
19e7397
to
98b78a5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
changluyi
force-pushed
the
add_golang_lint
branch
from
0d58263
to
87f58a3
Compare
oilbeater
requested changes
Sep 1, 2023
Makefile
Outdated
| @@ -828,6 +828,10 @@ lint: | |||
| @GOOS=linux go vet ./... | |||
| @GOOS=linux gosec -exclude=G204,G306,G404,G601,G301 -exclude-dir=test -exclude-dir=pkg/client ./... | |||
|
|
|||
| .PHONY: gofumpt | |||
| gofumpt: gofumpt | |||
| find . -name "*.go" -execdir gofumpt -w -extra {} \; | |||
There was a problem hiding this comment.
这里用 -w 重写了，那 lint 的问题是不是就检查不出来了，但是 git 仓库里还没改
There was a problem hiding this comment.
是的 ，这个步骤不该放流水线里面。可以手动执行。
changluyi
force-pushed
the
add_golang_lint
branch
from
a601e23
to
62c767f
Compare
zhangzujian
reviewed
Sep 6, 2023
changluyi
force-pushed
the
add_golang_lint
branch
from
62c767f
to
a69b068
Compare
oilbeater
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at ec95eea
Improved the linting workflow and configuration for the project. Added a
.github/workflows/.golangci.ymlfile to customize the golangci-lint tool and modified the.github/workflows/lint.yamlfile to use the new configuration and filter the relevant files.🤖 Generated by Copilot at ec95eea
HOW
🤖 Generated by Copilot at ec95eea
.golangci.ymlfile to configure the golangci-lint tool for the project (link).golangci.ymlfile is changed (link)