Add Layer 2 forwarding for subnet ports again #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirkrypt0
force-pushed
the
feature/layer2-forwarding-lsp
branch
from
ea0cb4d
to
200c7fb
Compare
|
In #2067 we refactored the feature by adding an We need to refactor the function |
This feature has been added previously, but fallen victim to a refactoring that removed it. We now add it back again. Signed-off-by: Tobias Kantusch <[email protected]>
zhangzujian
force-pushed
the
feature/layer2-forwarding-lsp
branch
from
200c7fb
to
56dbd1b
Compare
|
Thanks! @sirkrypt0 |
oilbeater
pushed a commit
that referenced
this pull request
Oct 31, 2023
This feature has been added previously, but fallen victim to a refactoring that removed it. We now add it back again. Signed-off-by: Tobias Kantusch <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
Nov 1, 2023
This feature has been added previously, but fallen victim to a refactoring that removed it. We now add it back again. Signed-off-by: Tobias Kantusch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been added in #1487 and then again in #2067, but fallen victim to a refactoring in
#2477 that removed it. We now add it back again.
What type of this PR
Feature/Bug Fix.
Which issue(s) this PR fixes:
Fixes #2043
WHAT
Adds the ability to configure a subnet port with addresses
unknownin OVN, such that the port gets all layer 2 packets. See #2043