fix dialing https server #4324
Merged
fix dialing https server #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pkg/util/k8s.go
Outdated
| case "tcp", "http": | ||
| conn, err = net.DialTimeout("tcp", address, timeout) | ||
| case "tls", "https": | ||
| conn, err = tls.DialWithDialer(&net.Dialer{Timeout: timeout}, "tcp", address, &tls.Config{InsecureSkipVerify: true}) |
Check failure
Code scanning / CodeQL
Disabled TLS certificate check High
Signed-off-by: zhangzujian <[email protected]>
zhangzujian
force-pushed
the
fix-ovn-controller-check
branch
from
0300251
to
a638a62
Compare
oilbeater
approved these changes
Jul 20, 2024
zhangzujian
added a commit
that referenced
this pull request
Jul 20, 2024
Signed-off-by: zhangzujian <[email protected]>
zhangzujian
added a commit
to zhangzujian/kube-ovn
that referenced
this pull request
Jul 20, 2024
Signed-off-by: zhangzujian <[email protected]>
bobz965
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: zhangzujian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Use
tls.Dialto dial tls/https server. Fixes the following error when secure serving is enabled: