Fix DISABLE_MODULES_MANAGEMENT #4363
Conversation
kvaps
force-pushed
the
fix-DISABLE_MODULES_MANAGEMENT
branch
from
0651fe7
to
f997986
Compare
kvaps
force-pushed
the
fix-DISABLE_MODULES_MANAGEMENT
branch
from
f997986
to
eaab811
Compare
| {{- if not .Values.DISABLE_MODULES_MANAGEMENT }} | ||
| - SYS_MODULE | ||
| {{- end }} |
There was a problem hiding this comment.
kube-ovn-cni will fail to start if we drop capability SYS_MODULE.
There was a problem hiding this comment.
Yeah you're right, this makes ovn totally incompatible with Talos Linux, because it is not allowed managing system modules by containers.
| @@ -81,18 +81,7 @@ spec: | |||
| {{- if .Values.DPDK }} | |||
| command: ["/kube-ovn/start-ovs-dpdk.sh"] | |||
| {{- else }} | |||
| command: | |||
| {{- if .Values.DISABLE_MODULES_MANAGEMENT }} | |||
There was a problem hiding this comment.
Why we introduced DISABLE_MODULES_MANAGEMENT? Is it related to https://github.com/kubeovn/kube-ovn/issues/4286？
There was a problem hiding this comment.
Because it is the only way for running kube-ovn on Talos Linux
kube-ovn/charts/kube-ovn/README.md
Line 24 in ed16ce5
There was a problem hiding this comment.
I have deployed my simple ovs daemonset inside talos and works fine. The problem is : modinfo is lying because it fetches the list of known modules by reading the /lib/modules/$(uname -r)/modules.* files, which are usually updated with depmod.
depmod -a can't run in talos and modinfo does not knows about it. openvswitch kernel module already supprted by talos and doesn't need to load it.
|
Closed in favor #4365 |
There is a regression introduced by #4326
Let's move this logic into
start-ovn.shscript