-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support ptp networks with ipv4 /31 netmask and ipv6 /127 netmask #4425
Conversation
Subnet checks fail for /32 subnets: status:
activateGateway: ""
conditions:
- lastTransitionTime: "2024-08-29T01:52:46Z"
lastUpdateTime: "2024-08-29T01:52:46Z"
message: 'validate gateway 1.1.1.0 for cidr 1.1.1.0/31 failed: 1.1.1.0 is the
network number ip in cidr 1.1.1.0/31'
reason: ValidateLogicalSwitchFailed
status: "True"
type: Error We need to fix it. |
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Co-authored-by: 张祖建 <[email protected]> Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
e9ab9f6
to
2c063ba
Compare
Signed-off-by: Karol Szwaj <[email protected]>
2c063ba
to
b76868f
Compare
Signed-off-by: Karol Szwaj <[email protected]>
Thanks for the review, I have added validation test cases @zhangzujian |
We need update IPAM to support p2p networks. |
Signed-off-by: Karol Szwaj <[email protected]>
hi @zhangzujian, I have added test cases for IPAM in the pkg/ipam |
Signed-off-by: Karol Szwaj <[email protected]>
I tried the following subnet and deployment but the kube-ovn could not handle the pod creation: apiVersion: kubeovn.io/v1
kind: ProviderNetwork
metadata:
name: ethx
spec:
defaultInterface: ethx
---
apiVersion: kubeovn.io/v1
kind: Vlan
metadata:
name: vlan0
spec:
id: 0
provider: ethx
---
apiVersion: kubeovn.io/v1
kind: Subnet
metadata:
name: s1
spec:
protocol: IPv4
cidrBlock: 1.1.1.0/31
vlan: vlan0
disableGatewayCheck: true
---
apiVersion: apps/v1
kind: Deployment
metadata:
name: kubeovn
namespace: default
spec:
selector:
matchLabels:
app: kubeovn
replicas: 2
template:
metadata:
labels:
app: kubeovn
annotations:
ovn.kubernetes.io/logical_switch: s1
ovn.kubernetes.io/ip_address: 1.1.1.0,1.1.1.1
spec:
containers:
- name: pod
imagePullPolicy: Never
# image: kubeovn/kube-ovn:v1.13.0
image: kubeovn/kube-ovn:dev
securityContext:
privileged: true
command:
- sleep
- infinity If this kind of usage is wrong, please tell me how to use /31 subnets correctly. |
I see, this could cause a problem with trying to assign 1.1.1.0 to a Pod, which might be a problem. |
…kubeovn#4425) Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: 张祖建 <[email protected]> Signed-off-by: liyh <[email protected]>
…#4425) Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: 张祖建 <[email protected]>
Pull Request
What type of this PR
Examples of user facing changes:
It would be valuable for kube-ovn to support ptp networks, to create external subnets between kube-ovn and the router, following RFC 3021 and RFC 6164.
Which issue(s) this PR fixes
Fixes