[fix]: delete the NIC regardless of whether the Pod was found or not. #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
…vn#4458) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.34.1 to 1.34.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.34.1...v1.34.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
Signed-off-by: liyh-yusur <[email protected]> Signed-off-by: liyh <[email protected]>
…n#4467) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6 to 7. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v6...v7) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
kubeovn#4469) Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.13 to 1.1.14. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/main/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.13...v1.1.14) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
Signed-off-by: zcq98 <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: Bogdan Christescu <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: 马洪贞 <[email protected]> Signed-off-by: liyh <[email protected]>
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.24.0 to 0.25.0. - [Commits](golang/sys@v0.24.0...v0.25.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: zcq98 <[email protected]> Signed-off-by: liyh <[email protected]>
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.20.0 to 0.21.0. - [Commits](golang/mod@v0.20.0...v0.21.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
* fix bug: dpdk场景下添加删除ProviderNetwork失败 Signed-off-by: wangs <[email protected]> * fix err log Signed-off-by: wangs <[email protected]> * fix err log Signed-off-by: wangs <[email protected]> * fix link set error Signed-off-by: wangs <[email protected]> * fix del bridge err Signed-off-by: wangs <[email protected]> --------- Signed-off-by: wangs <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: oilbeater <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: wangs <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
* add ipam ut Signed-off-by: bobz965 <[email protected]> * add ut Signed-off-by: bobz965 <[email protected]> * fix log Signed-off-by: bobz965 <[email protected]> --------- Signed-off-by: bobz965 <[email protected]> Signed-off-by: liyh <[email protected]>
* add subnet ipam ut Signed-off-by: bobz965 <[email protected]> * add subnet ipam ut Signed-off-by: bobz965 <[email protected]> * add subnet ut Signed-off-by: bobz965 <[email protected]> --------- Signed-off-by: bobz965 <[email protected]> Signed-off-by: liyh <[email protected]>
* add unit test for ovn-nb-address_set.go Signed-off-by: zcq98 <[email protected]> * add unit test for ovn-nb-acl.go Signed-off-by: zcq98 <[email protected]> * add unit test for ovn-nb-bfd.go Signed-off-by: zcq98 <[email protected]> --------- Signed-off-by: zcq98 <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: bobz965 <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: bobz965 <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
…kubeovn#4425) Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: 张祖建 <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: liyh <[email protected]>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.2.0+incompatible to 27.2.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.2.0...v27.2.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: liyh <[email protected]>
Signed-off-by: zhangzujian <[email protected]> Signed-off-by: liyh <[email protected]>
* add mcast querier ip for multicast --------- Signed-off-by: clyi <[email protected]> Signed-off-by: liyh <[email protected]>
Signed-off-by: liyh <[email protected]>
Signed-off-by: liyh <[email protected]>
Signed-off-by: liyh <[email protected]>
dosubot
bot
added
size:XXL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Describe
当删除pod时，若pod被直接删除cni来不及处理时，通过
pod, err := csh.Controller.podsLister.Pods(podRequest.PodNamespace).Get(podRequest.PodName)获取pod进行后续的处理条件，会导致此时无法处理，直接在k8serrors.IsNotFound中返回。复现
例如 在pod的部署yaml中设置了terminationGracePeriodSeconds: 0，导致 Pod 在删除 Deployment 后被立即终止，而 CNI 插件的 handleDel 函数还没来得及处理删除网卡的操作。
使用 podRequest.ContainerID 来识别 Pod，而不是使用 podRequest.PodName。这样即使 Pod 已经被删除，CNI 插件仍然可以通过容器 ID 来删除网卡。
spec: containers: - name: iperf3-server image: harbor.yusur.tech/yusur_ovn/iperf3 args: ['-s','-p','5001'] resources: requests: yusur.tech/sriov_dpu: '1' limits: yusur.tech/sriov_dpu: '1' ports: - containerPort: 5001 name: server terminationGracePeriodSeconds: 0 nodeSelector: app: node1