Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to set vxlan_sys_4789 tx off #4543

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

bobz965
Copy link
Collaborator

@bobz965 bobz965 commented Sep 21, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

if user has some machine os nic which can not use vxlan_sys_4789 tx on, allow user to set it off.

Which issue(s) this PR fixes

Fixes #(issue-number)

@bobz965 bobz965 marked this pull request as ready for review September 21, 2024 06:41
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working chart Helm Chart labels Sep 21, 2024
@@ -119,6 +119,7 @@ spec:
- --ovs-vsctl-concurrency={{ .Values.performance.OVS_VSCTL_CONCURRENCY }}
- --secure-serving={{- .Values.func.SECURE_SERVING }}
- --enable-ovn-ipsec={{- .Values.func.ENABLE_OVN_IPSEC }}
- --set-tx-off={{- .Values.func.SET_TX_OFF }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--set-vxlan-tx-off is more clear

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: bobz965 <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@oilbeater oilbeater merged commit 5a70de9 into kubeovn:master Sep 23, 2024
61 of 62 checks passed
@bobz965 bobz965 deleted the allow-vxlan-tx-off branch September 23, 2024 05:28
bobz965 added a commit that referenced this pull request Oct 25, 2024
* allow set vxlan nic tx off

---------

Signed-off-by: bobz965 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart Helm Chart lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants