-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow user to set vxlan_sys_4789 tx off #4543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
Signed-off-by: bobz965 <[email protected]>
bobz965
force-pushed
the
allow-vxlan-tx-off
branch
from
September 21, 2024 06:41
473e14f
to
65ce36c
Compare
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
bug
Something isn't working
chart
Helm Chart
labels
Sep 21, 2024
oilbeater
requested changes
Sep 23, 2024
@@ -119,6 +119,7 @@ spec: | |||
- --ovs-vsctl-concurrency={{ .Values.performance.OVS_VSCTL_CONCURRENCY }} | |||
- --secure-serving={{- .Values.func.SECURE_SERVING }} | |||
- --enable-ovn-ipsec={{- .Values.func.ENABLE_OVN_IPSEC }} | |||
- --set-tx-off={{- .Values.func.SET_TX_OFF }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--set-vxlan-tx-off
is more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: bobz965 <[email protected]>
oilbeater
approved these changes
Sep 23, 2024
bobz965
added a commit
that referenced
this pull request
Oct 25, 2024
* allow set vxlan nic tx off --------- Signed-off-by: bobz965 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
if user has
some machine os nic
which can not use vxlan_sys_4789 tx on, allow user to set it off.Which issue(s) this PR fixes
Fixes #(issue-number)