Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add utils ut #4544

Merged
merged 2 commits into from
Sep 23, 2024
Merged

add utils ut #4544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4279ec
add utils ut
bobz965 Sep 21, 2024
fad9d2f
fix lint
bobz965 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/util/k8s.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ func ServiceClusterIPs(svc v1.Service) []string {
func LabelSelectorNotEquals(key, value string) (labels.Selector, error) {
requirement, err := labels.NewRequirement(key, selection.NotEquals, []string{value})
if err != nil {
klog.Errorf("failed to create label requirement: %v", err)
return nil, err
}
return labels.Everything().Add(*requirement), nil
Expand Down
275 changes: 275 additions & 0 deletions pkg/util/k8s_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package util

import (
"context"
"errors"
"net"
"net/http"
Expand All @@ -9,8 +10,11 @@ import (
"testing"
"time"

"github.com/stretchr/testify/require"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes/fake"
clientv1 "k8s.io/client-go/kubernetes/typed/core/v1"
"k8s.io/klog/v2"
)

Expand Down Expand Up @@ -197,3 +201,274 @@ func TestGetNodeInternalIP(t *testing.T) {
})
}
}

func TestGetPodIPs(t *testing.T) {
tests := []struct {
name string
pod v1.Pod
exp []string
}{
{
name: "pod_with_one_pod_ip",
pod: v1.Pod{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.PodSpec{},
Status: v1.PodStatus{
PodIPs: []v1.PodIP{{IP: "192.168.1.100"}},
PodIP: "192.168.1.100",
},
},
exp: []string{"192.168.1.100"},
},
{
name: "pod_with_one_pod_ip",
pod: v1.Pod{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.PodSpec{},
Status: v1.PodStatus{
PodIPs: []v1.PodIP{{IP: "192.168.1.100"}, {IP: "fd00:10:16::8"}},
PodIP: "192.168.1.100",
},
},
exp: []string{"192.168.1.100", "fd00:10:16::8"},
},

{
name: "pod_with_no_pod_ip",
pod: v1.Pod{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.PodSpec{},
Status: v1.PodStatus{
PodIPs: []v1.PodIP{},
PodIP: "",
},
},
exp: []string{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if ret := PodIPs(tt.pod); len(ret) != len(tt.exp) {
t.Errorf("got %v, want %v", ret, tt.exp)
}
})
}
}

func TestServiceClusterIPs(t *testing.T) {
tests := []struct {
name string
svc v1.Service
exp []string
}{
{
name: "service_with_one_cluster_ip",
svc: v1.Service{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.ServiceSpec{
ClusterIP: "10.96.0.1",
ClusterIPs: []string{"10.96.0.1"},
},
},
exp: []string{"10.96.0.1"},
},
{
name: "service_with_two_cluster_ip",
svc: v1.Service{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.ServiceSpec{
ClusterIP: "10.96.0.1",
ClusterIPs: []string{"10.96.0.1", "fd00:10:16::1"},
},
},
exp: []string{"10.96.0.1", "fd00:10:16::1"},
},
{
name: "service_with_no_cluster_ip",
svc: v1.Service{
TypeMeta: metav1.TypeMeta{},
ObjectMeta: metav1.ObjectMeta{},
Spec: v1.ServiceSpec{
ClusterIP: "",
ClusterIPs: []string{},
},
},
exp: []string{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if ret := ServiceClusterIPs(tt.svc); len(ret) != len(tt.exp) {
t.Errorf("got %v, want %v", ret, tt.exp)
}
})
}
}

func TestUpdateNodeLabels(t *testing.T) {
client := fake.NewSimpleClientset()
nodeClient := client.CoreV1().Nodes()
tests := []struct {
name string
cs clientv1.NodeInterface
node string
labels map[string]any
exp error
}{
{
name: "node_with_labels",
cs: nodeClient,
node: "node1",
labels: map[string]any{
"key1": "value1",
},
exp: nil,
},
{
name: "node_with_nil_labels",
cs: nodeClient,
node: "node2",
labels: map[string]any{},
exp: nil,
},
}
for _, tt := range tests {
// create a node
node, err := client.CoreV1().Nodes().Create(context.Background(), &v1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: tt.node,
},
}, metav1.CreateOptions{})
require.NoError(t, err)
require.NotNil(t, node)
t.Run(tt.name, func(t *testing.T) {
err := UpdateNodeLabels(tt.cs, tt.node, tt.labels)
if tt.exp == nil {
require.NoError(t, err)
return
}
if errors.Is(err, tt.exp) {
t.Errorf("got %v, want %v", err, tt.exp)
}
})
}
}

func TestUpdateNodeAnnotations(t *testing.T) {
client := fake.NewSimpleClientset()
nodeClient := client.CoreV1().Nodes()
tests := []struct {
name string
cs clientv1.NodeInterface
node string
annotations map[string]any
exp error
}{
{
name: "node_with_annotations",
cs: nodeClient,
node: "node1",
annotations: map[string]any{
"key1": "value1",
},
exp: nil,
},
{
name: "node_with_nil_annotations",
cs: nodeClient,
node: "node2",
annotations: map[string]any{},
exp: nil,
},
}
for _, tt := range tests {
// create a node
node, err := client.CoreV1().Nodes().Create(context.Background(), &v1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: tt.node,
},
}, metav1.CreateOptions{})
require.NoError(t, err)
require.NotNil(t, node)
t.Run(tt.name, func(t *testing.T) {
err := UpdateNodeAnnotations(tt.cs, tt.node, tt.annotations)
if tt.exp == nil {
require.NoError(t, err)
return
}
if errors.Is(err, tt.exp) {
t.Errorf("got %v, want %v", err, tt.exp)
}
})
}
}

func TestNodeMergePatch(t *testing.T) {
client := fake.NewSimpleClientset()
nodeClient := client.CoreV1().Nodes()
tests := []struct {
name string
cs clientv1.NodeInterface
node string
patch string
exp error
}{
{
name: "node_with_patch",
cs: nodeClient,
node: "node",
patch: `{"metadata":{"labels":{"key1":"value1"}}}`,
exp: nil,
},
}
for _, tt := range tests {
// create a node
node, err := client.CoreV1().Nodes().Create(context.Background(), &v1.Node{
ObjectMeta: metav1.ObjectMeta{
Name: tt.node,
},
}, metav1.CreateOptions{})
require.NoError(t, err)
require.NotNil(t, node)
t.Run(tt.name, func(t *testing.T) {
err := nodeMergePatch(tt.cs, tt.node, tt.patch)
if tt.exp == nil {
require.NoError(t, err)
return
}
if errors.Is(err, tt.exp) {
t.Errorf("got %v, want %v", err, tt.exp)
}
})
}
}

func TestLabelSelectorNotEquals(t *testing.T) {
selector, err := LabelSelectorNotEquals("key", "value")
require.NoError(t, err)
require.Equal(t, "key!=value", selector.String())
// Test error case
selector, err = LabelSelectorNotEquals("", "")
require.Error(t, err)
require.Nil(t, selector)
}

func TestLabelSelectorNotEmpty(t *testing.T) {
selector, err := LabelSelectorNotEmpty("key")
require.NoError(t, err)
require.Equal(t, "key!=", selector.String())
// Test error case
selector, err = LabelSelectorNotEmpty("")
require.Error(t, err)
require.Nil(t, selector)
}

func TestGetTruncatedUID(t *testing.T) {
uid := "12345678-1234-1234-1234-123456789012"
require.Equal(t, "123456789012", GetTruncatedUID(uid))
}
Loading