debug pidfile

Signed-off-by: zhangzujian <[email protected]>
kubeovn · Nov 13, 2023 · c784c74 · c784c74
1 parent 6a29598
commit c784c74
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c
@@ -490,6 +490,8 @@ daemonize_start(bool access_datapath)
 
     if (pidfile) {
         make_pidfile();
+    } else {
+        VLOG_WARN("pidfile is NULL");
     }
 
     /* Make sure that the unixctl commands for vlog get registered in a
@@ -507,6 +509,7 @@ daemonize_complete(void)
 {
     if (pidfile) {
         free(pidfile);
+        VLOG_WARN("daemonize_complete, setting pidfile to NULL");
         pidfile = NULL;
     }
 

diff --git a/lib/daemon.c b/lib/daemon.c
@@ -61,9 +61,11 @@ daemonize(void)
 void
 set_pidfile(const char *name)
 {
+    VLOG_WARN("set_pidfile(%s)", name);
     assert_single_threaded();
     free(pidfile);
     pidfile = make_pidfile_name(name);
+    VLOG_WARN("pidfile is set to %s", pidfile);
 }
 
 /* Disables self confinement. */

diff --git a/lib/daemon.h b/lib/daemon.h
@@ -50,7 +50,7 @@
         {"detach",            no_argument, NULL, OPT_DETACH},            \
         {"no-self-confinement", no_argument, NULL, OPT_NO_SELF_CONFINEMENT}, \
         {"no-chdir",          no_argument, NULL, OPT_NO_CHDIR},          \
-        {"pidfile",           optional_argument, NULL, OPT_PIDFILE},     \
+        {"pidfile",           required_argument, NULL, OPT_PIDFILE},     \
         {"overwrite-pidfile", no_argument, NULL, OPT_OVERWRITE_PIDFILE}, \
         {"monitor",           no_argument, NULL, OPT_MONITOR},           \
         {"user",              required_argument, NULL, OPT_USER_GROUP}
@@ -113,7 +113,7 @@ pid_t read_pidfile(const char *name);
         {"detach",             no_argument, NULL, OPT_DETACH},            \
         {"no-self-confinement", no_argument, NULL, OPT_NO_SELF_CONFINEMENT}, \
         {"no-chdir",           no_argument, NULL, OPT_NO_CHDIR},          \
-        {"pidfile",            optional_argument, NULL, OPT_PIDFILE},     \
+        {"pidfile",            required_argument, NULL, OPT_PIDFILE},     \
         {"pipe-handle",        required_argument, NULL, OPT_PIPE_HANDLE}, \
         {"service",            no_argument, NULL, OPT_SERVICE},           \
         {"service-monitor",    no_argument, NULL, OPT_SERVICE_MONITOR},   \