Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #1700

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Update dependencies #1700

merged 4 commits into from
Aug 17, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
Updating dependencies, notable ones are:

  • k8s API to v1.28.0
  • controller-runtime to v1.15.1
  • AWS SDK to v1.20.1

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@ahmedwaleedmalik
Update k8s APIs to v1.28
9291e54 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Satisfy fake clients requirement of finalizers with DeletionTimeStamp
6eafbb2 
Fake client won't create objects after kubernetes-sigs/controller-runtime#2316 if they have DeletionTimeStamp without finalizers

Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik requested a review from xrstf August 16, 2023 16:53
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Aug 16, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 16, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 16, 2023
@ahmedwaleedmalik
Copy link
Member Author

This script was unable to determine the external IP for kube-apiserver.

The failures till now are just flakes.
/retest

@ahmedwaleedmalik
Copy link
Member Author

@xrstf we'll have to override pull-machine-controller-e2e-vmware-cloud-director, we are hitting #1619. Not sure when we can finally get it fixed though :/

@kron4eg
Copy link
Member

kron4eg commented Aug 16, 2023

is this a good idea? it will force the same changes on KKP and KubeOne

@ahmedwaleedmalik
Copy link
Member Author

ahmedwaleedmalik commented Aug 16, 2023 •
edited
Loading

is this a good idea? it will force the same changes on KKP and KubeOne

I think when KKP and KubeOne start supporting k8s 1.28 then these dependencies for k8s API and controller-runtime etc should be updated as well. Should be the same for other dependencies.

Since this change is only for the main branch at the moment; it'll make its way into KKP 2.24 and KubeOne 1.8; the next minor releases.

Honestly, I don't like updating all of this in a single PR as well but this is the only feasible way due to limited capacity. Otherwise, these things would never get updated.

@ahmedwaleedmalik
Refactored code
39e5cee 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik ahmedwaleedmalik requested a review from xrstf August 17, 2023 08:22
@xrstf
Copy link
Contributor

xrstf commented Aug 17, 2023

/override pull-machine-controller-e2e-vmware-cloud-director
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f43a3bc53a3afba1bcb67c5699e42055a53e696

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vmware-cloud-director

In response to this:

/override pull-machine-controller-e2e-vmware-cloud-director
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 8957c01 into kubermatic:main Aug 17, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the update-deps branch August 17, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg @xrstf