Skip to content

feat: add support for other security providers on legacy-22 branch #3994 #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

silbermannnn
Copy link

@silbermannnn silbermannnn commented Apr 25, 2025

Cherrypick changes from 3595 into legacy-22-fix branch for #3994

Dynamically load security providers using the Java Service Provider Interface.

This allows the user to pick the provider based upon the dependencies it has on its classpath.

Dynamically load security providers using the Java Service Provider Interface.

This allows the user to pick the provider based upon the dependencies it has on
its classpath.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2025
@silbermannnn silbermannnn changed the title feat: add support for other security providers 22-fix #3994 feat: add support for other security providers on legacy-22-fix #3994 Apr 25, 2025
@brendandburns
Copy link
Contributor

Looks good but please fix the commit message.

@silbermannnn silbermannnn changed the title feat: add support for other security providers on legacy-22-fix #3994 feat: add support for other security providers on legacy-22-1 branch #3994 Apr 28, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 28, 2025
@silbermannnn silbermannnn changed the title feat: add support for other security providers on legacy-22-1 branch #3994 feat: add support for other security providers on legacy-22 branch #3994 Apr 28, 2025
@brendandburns
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, silbermannnn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 42d9e17 into kubernetes-client:release-legacy-22-fix Apr 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants