-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Protobuf Matcher utility #553
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-csi:master
from
AndrewSirenko:AddProtobufMatcher
Aug 29, 2024
Merged
Add Protobuf Matcher utility #553
k8s-ci-robot
merged 1 commit into
kubernetes-csi:master
from
AndrewSirenko:AddProtobufMatcher
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-action-required
Denotes a PR that introduces potentially breaking changes that require user action.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Aug 28, 2024
k8s-ci-robot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
Aug 28, 2024
gnufied
reviewed
Aug 28, 2024
AndrewSirenko
force-pushed
the
AddProtobufMatcher
branch
from
August 28, 2024 15:09
f2c7b14
to
1aab2d9
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Aug 28, 2024
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 29, 2024
/cherry-pick release-5.3 |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 30, 2024
Cherry-pick #553: Add Protobuf Matcher utility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note-action-required
Denotes a PR that introduces potentially breaking changes that require user action.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/feature
What this PR does / why we need it:
Source: @jsafrane's kubernetes-csi/external-provisioner#1262
gomock is not able to match newly generated Protobuf messages from csi-test, because their private fields differ. Implement a custom message matcher for projects that need to mock gRPCs can use.
See the passing tests in the following PRs for proof that this works as intended (which rely on a replace directive pointing to my fork of csi-test):
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Will rebase other PRs in sidecar repositories once we release a new patch version of csi-test.
We should cherry-pick this to
release-5.3
.Does this PR introduce a user-facing change?: