Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CSI spec 1.10 #1262

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bump CSI spec 1.10 #1262

wants to merge 4 commits into from

Commits on Sep 19, 2024

  1. Bump CSI spec to 1.10.0 

    And csi-test to 5.3.0 to get updated mocks.
    @jsafrane
    jsafrane committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1bc306d View commit details
    Browse the repository at this point in the history

  2. Update unit tests to new gRPC 

    gomock cannot compare protobuf messages due to mismatches in private
fields. Use a custom matcher for protobuf messages.
    @jsafrane
    jsafrane committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    1416604 View commit details
    Browse the repository at this point in the history

  3. Fix panic in topology tests 

    k8s.io/apimachinery can be used to compare API objects, but it panics on
protobuf messages. Use a generic cmp.Equal, with protobuf hints.
    @jsafrane
    jsafrane committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e26da09 View commit details
    Browse the repository at this point in the history

  4. Fix govet errors 

    Do not copy NodeGetInfoResponse, it contains many private fields, incl. a
mutex that should not be copied. Use a pointer instead.
    @jsafrane
    jsafrane committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d794397 View commit details
    Browse the repository at this point in the history