Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributed provisioning: avoid errors from lib about foreign nodes #670

Closed
wants to merge 1 commit into from

Commits on Sep 2, 2021

  1. distributed provisioning: avoid errors from lib about foreign nodes

    The provisioner receives PVCs for all nodes. This is necessary to support
    provisioning of PVCs with immediate binding. When it receives a PVC with a
    selected node that isn't the local one, the fake node informer didn't have an
    object for that node, which caused this error and a corresponding event:
    
      E0902 17:33:24.229890       1 controller.go:981] error syncing claim "f5008265-3c43-4385-a78d-4fa3f72fb611": failed to get target node: node "aks-workerpool-15818640-vmss00000a" not found
    
    This could be avoided if the lib didn't look up the node for the
    provisioner. We discussed that a while back and decided against it at the
    time. Given that situation, the simplest solution is to ensure that the lib
    always gets a node object.
    pohly committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    c861f28 View commit details
    Browse the repository at this point in the history