Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add change log for 0.5.1 release #112

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add change log for 0.5.1 release #112

merged 1 commit into from
Oct 7, 2020

Conversation

Jiawei0227
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add change log for 0.5.1 release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/cc @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2020
msau42
msau42 reviewed Oct 7, 2020
View reviewed changes
CHANGELOG-0.5.md Outdated
### Feature

- Add `process_start_time_seconds` metric. ([#106](https://github.com/kubernetes-csi/external-resizer/pull/106), [@Jiawei0227](https://github.com/Jiawei0227))
- Adding configurable QPS and Burst to k8s client and use a separate client for leader election. ([#91](https://github.com/kubernetes-csi/external-resizer/pull/91), [@RaunakShah](https://github.com/RaunakShah))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm something doesn't seem right with the release notes tool. these two changes were only in 1.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is related to kubernetes-csi/csi-release-tools#7 (comment)

Fixed this by manually updated the release notes.

CHANGELOG-0.5.md Outdated
### Uncategorized

- Build with Go 1.15 ([#98](https://github.com/kubernetes-csi/external-resizer/pull/98), [@pohly](https://github.com/pohly))
- Publishing of images on k8s.gcr.io ([#84](https://github.com/kubernetes-csi/external-resizer/pull/84), [@pohly](https://github.com/pohly))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hm we need to backport some more changes to actually make this work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's going to be too much effort to backport the cloudbuild changes and fix the current multiarch build failure. I propose that we release these patches using the old travis method, and then copy the images over to gcr

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2020
msau42
msau42 reviewed Oct 7, 2020
View reviewed changes
CHANGELOG-0.5.md

### Uncategorized

- release-0.5: update release-tools ([#110](https://github.com/kubernetes-csi/external-resizer/pull/75), [@Jiawei0227](https://github.com/Jiawei0227))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note here saying this also updates the go version to 1.15?

@msau42
Copy link
Collaborator

msau42 commented Oct 7, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jiawei0227, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6cd2f77 into kubernetes-csi:release-0.5 Oct 7, 2020
xing-yang added a commit that referenced this pull request Nov 14, 2020
@xing-yang
Squashed 'release-tools/' changes from 4aff857..5d874cc
fe2847e 
5d874cc Merge pull request #112 from xing-yang/cleanup
79bbca7 Cleanup
d437673 Merge pull request #111 from xing-yang/update_snapshot_v1_rc
57718f8 Update snapshot CRD version

git-subtree-dir: release-tools
git-subtree-split: 5d874cce4e649dfd254d01b9b44179ffa72aee75
@xing-yang xing-yang mentioned this pull request Nov 14, 2020
Merged
jsafrane pushed a commit to jsafrane/external-resizer that referenced this pull request Jan 4, 2021
@openshift-merge-robot
Merge pull request kubernetes-csi#112 from jsafrane/rebase-v1.0.0
22efbdd 
Bug 1876791: Rebase to v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiawei0227 @msau42 @k8s-ci-robot