Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-3.0: Update release tools #436

Closed

Conversation

ggriffiths
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates this branch to latest rel tools

Which issue(s) this PR fixes:
n/a

Special notes for your reviewer:
n/a

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 3, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2020
@ggriffiths
Copy link
Member Author

/assign @xing-yang

@ggriffiths ggriffiths changed the title release-3.0: Update to latest release tools release-3.0: Update to release tools 5d874cce4e649dfd254d01b9b44179ffa72aee75 Dec 3, 2020
@ggriffiths ggriffiths changed the title release-3.0: Update to release tools 5d874cce4e649dfd254d01b9b44179ffa72aee75 release-3.0: Update release tools Dec 3, 2020
@ggriffiths
Copy link
Member Author

Includes all changes from release-tools master up until commit 5d874cc.

The latest release tools were failing on this branch: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-snapshotter/436/pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19/1334383791833092096

@pohly
Copy link
Contributor

pohly commented Dec 3, 2020

The latest release tools were failing on this branch

This needs to be fixed. We can't be stuck on a non-recent csi-release-tools.

@xing-yang
Copy link
Collaborator

@ggriffiths we need to squash the commits. Can you try this script: kubernetes-csi/csi-release-tools#7 (comment)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ggriffiths
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 3, 2020
@ggriffiths
Copy link
Member Author

Ok, I've reopened a new PR with the script - had issues pushing directly to this branch and it was closed.
#437

@k8s-ci-robot
Copy link
Contributor

@ggriffiths: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-1-17 271a825 link /test pull-kubernetes-csi-external-snapshotter-1-17-on-kubernetes-1-17
pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19 271a825 link /test pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19
pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-1-18 271a825 link /test pull-kubernetes-csi-external-snapshotter-1-18-on-kubernetes-1-18

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants