-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-3.0: Update release tools #436
Conversation
/assign @xing-yang |
6d3d7a8
to
b4048b6
Compare
Includes all changes from release-tools master up until commit 5d874cc. The latest release tools were failing on this branch: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-csi_external-snapshotter/436/pull-kubernetes-csi-external-snapshotter-1-19-on-kubernetes-1-19/1334383791833092096 |
This needs to be fixed. We can't be stuck on a non-recent csi-release-tools. |
@ggriffiths we need to squash the commits. Can you try this script: kubernetes-csi/csi-release-tools#7 (comment) |
b4048b6
to
271a825
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ggriffiths The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ok, I've reopened a new PR with the script - had issues pushing directly to this branch and it was closed. |
@ggriffiths: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Updates this branch to latest rel tools
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
n/a
Does this PR introduce a user-facing change?: