This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
vendor: update vendoring #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
I got pretty confused by the vendoring and the changes in kubernetes but it now compiles and seems to work. |
|
@iaguis why using rkt v1.25.0 instead of the last release? |
|
I chose that kinda arbitrarily because that's what k8s vendors. Although I see not that it's only us (rktlet) that use it. I'll change it to the last release and also do |
|
Travis fails because |
iaguis
force-pushed
the
iaguis/update-vendoring
branch
from
3950aae
to
5ec404c
Compare
|
It's green now :) |
|
It compiles fine for me. A couple of changes in the rkt git repository were missed: After the changes mentioned above, LGTM. |
It now uses: * Kubernetes v1.7.5 * rkt v1.25.0 * go-systemd v15 I had to explicitly list some dependencies to pin them to a version * client-go v4.0.0 * cni v0.3.0 (what rkt uses) I also changed some depencency revisions to match what Kubernetes has. Finally, since I was getting compilation errors similar to the ones mentioned in kelseyhightower/kubernetes-initializer-tutorial#4, I set the version of k8s.io/apimachinery to like mentioned there.
It's now github.com/rkt/rkt
iaguis
force-pushed
the
iaguis/update-vendoring
branch
from
5ec404c
to
f6e0c4e
Compare
|
Thanks! I fixed those and also removed |
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses:
I had to explicitly list some dependencies to pin them to a version
I also changed some depencency revisions to match what Kubernetes has.
Finally, since I was getting compilation errors similar to the ones
mentioned in kelseyhightower/kubernetes-initializer-tutorial#4,
I set the version of k8s.io/apimachinery like mentioned there.