-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: parse featureGates as map #1251
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AlbeeSo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This will pose extra challenge to our ACK release tools, which cannot handle such complex logic. And I doubt if this is necessary. Some extra RBAC for new CRs should be fine. And feature gates are expected to be true for everyone in the future, so all necessary permissions should be acceptable for everyone. Feature gate is just for cluster admin to acknowledge that this feature is not stable yet. |
Error: template: alibaba-cloud-csi-driver/templates/rbac.yaml:47:45: executing "alibaba-cloud-csi-driver/templates/rbac.yaml" at <$featureGates>: wrong type for value; expected string; got []interface {} |
@huww98 Flags on sidecars by default may cause unexpected warning logs. Let users set feature-gates by hand according to the document is a way to announce them some extra RBACs are added. Even permissions are all acceptable for everyone, they are unnecessary. |
Done. |
CSI includes kinds of feature-gates, which may lead different configuration on helm templates. For example, to minimize rbac rules, and to set flags for sidecars only when related feature-gates enabled.
This PR involves a
parseFeatureGates
function in helm to help this and apply toEnableVolumeGroupSnapshots
feature.What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: