Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: parse featureGates as map #1251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented Dec 5, 2024

CSI includes kinds of feature-gates, which may lead different configuration on helm templates. For example, to minimize rbac rules, and to set flags for sidecars only when related feature-gates enabled.
This PR involves a parseFeatureGates function in helm to help this and apply to EnableVolumeGroupSnapshots feature.

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from mowangdk December 5, 2024 09:05
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbeeSo
Once this PR has been reviewed and has the lgtm label, please assign mowangdk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2024
@huww98
Copy link
Contributor

huww98 commented Dec 5, 2024

This will pose extra challenge to our ACK release tools, which cannot handle such complex logic.

And I doubt if this is necessary. Some extra RBAC for new CRs should be fine. And feature gates are expected to be true for everyone in the future, so all necessary permissions should be acceptable for everyone. Feature gate is just for cluster admin to acknowledge that this feature is not stable yet.

@huww98
Copy link
Contributor

huww98 commented Dec 5, 2024

Error: template: alibaba-cloud-csi-driver/templates/rbac.yaml:47:45: executing "alibaba-cloud-csi-driver/templates/rbac.yaml" at <$featureGates>: wrong type for value; expected string; got []interface {}

@AlbeeSo
Copy link
Member Author

AlbeeSo commented Dec 6, 2024

This will pose extra challenge to our ACK release tools, which cannot handle such complex logic.

And I doubt if this is necessary. Some extra RBAC for new CRs should be fine. And feature gates are expected to be true for everyone in the future, so all necessary permissions should be acceptable for everyone. Feature gate is just for cluster admin to acknowledge that this feature is not stable yet.

@huww98 Flags on sidecars by default may cause unexpected warning logs. Let users set feature-gates by hand according to the document is a way to announce them some extra RBACs are added. Even permissions are all acceptable for everyone, they are unnecessary.

@AlbeeSo
Copy link
Member Author

AlbeeSo commented Dec 6, 2024

Error: template: alibaba-cloud-csi-driver/templates/rbac.yaml:47:45: executing "alibaba-cloud-csi-driver/templates/rbac.yaml" at <$featureGates>: wrong type for value; expected string; got []interface {}

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants