feat(nas): automatic CNFS switching when mounting NAS volumes #1262
Conversation
k8s-ci-robot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: iltyty The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @iltyty. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
| } | ||
|
|
||
| func getPodFromK8s(ctx context.Context, client kubernetes.Interface, req *csi.NodePublishVolumeRequest) (*v1.Pod, error) { |
There was a problem hiding this comment.
How about passing the ctx to the Get() below, instead of removing it?
| case v1beta1.FallbackStrategyIfConnectFailed: | ||
| server := cnfs.Spec.Parameters.Server | ||
| dialer := net.Dialer{Timeout: 5 * time.Second} | ||
| _, err := dialer.Dial("tcp", server+":2049") |
There was a problem hiding this comment.
Better to use DialContext and explicitly close the returned conn object.
| func (ns *nodeServer) fallbackCNFSAndRecord(ctx context.Context, req *csi.NodePublishVolumeRequest, cnfs *v1beta1.ContainerNetworkFileSystem) (*v1beta1.ContainerNetworkFileSystem, error) { | ||
| oldName, newName := cnfs.Name, cnfs.Spec.Fallback.Name | ||
| pod, err := utils.GetPodFromContextOrK8s(ctx, ns.config.KubeClient, req) | ||
| if err != nil { |
There was a problem hiding this comment.
I think we can just skip the event if this fails?
| for { | ||
| conn, _ := listener.Accept() | ||
| if conn != nil { | ||
| conn.Close() | ||
| } | ||
| } |
There was a problem hiding this comment.
This will not terminate after the test case finishes. How about making use of t.Cleanup()?
| switch tt.primaryCNFS.Spec.Fallback.Strategy { | ||
| case v1beta1.FallbackStrategyAlways: | ||
| assert.Contains(t, msg, fmt.Sprintf(cnfsAlwaysFallbackEventTmpl, oldCNFSName, newCNFSName)) | ||
| case v1beta1.FallbackStrategyIfConnectFailed: | ||
| assert.Contains(t, msg, fmt.Sprintf(cnfsIfConnectFailedFallbackEventTmpl, oldCNFSName, newCNFSName)) | ||
| case v1beta1.FallbackStrategyIfMountTargetUnhealthy: | ||
| assert.Contains(t, msg, fmt.Sprintf(cnfsIfMountTargetUnhealthyFallbackEventTmpl, oldCNFSName, newCNFSName)) | ||
| } |
There was a problem hiding this comment.
How about add a expectedEvent field to tests, instead of copy pasting a large segment of code?
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@iltyty: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: