Skip to content

Commit

Permalink
Merge pull request #2220 from ElijahQuinones/vac
Browse files Browse the repository at this point in the history
Enable VAC tests
  • Loading branch information
k8s-ci-robot authored Nov 8, 2024
2 parents 596ace5 + 56062d2 commit ef505ff
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 12 deletions.
2 changes: 2 additions & 0 deletions tests/e2e-kubernetes/manifests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
ShortName: ebs
StorageClass:
FromFile: storageclass.yaml
VolumeAttributesClass:
FromFile: volumeattributesclass.yaml
SnapshotClass:
FromName: true
DriverInfo:
Expand Down
3 changes: 0 additions & 3 deletions tests/e2e-kubernetes/storageclass.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# StorageClass for Kubernetes external tests.
# See https://github.com/kubernetes/kubernetes/tree/master/test/e2e/storage/external

kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
Expand Down
21 changes: 21 additions & 0 deletions tests/e2e-kubernetes/volumeattributesclass.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Copyright 2024 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the 'License');
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an 'AS IS' BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: storage.k8s.io/v1beta1
kind: VolumeAttributesClass
metadata:
name: gp2-class
driverName: ebs.csi.aws.com
parameters:
type: gp2
12 changes: 3 additions & 9 deletions tests/e2e/modify_volume.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ limitations under the License.
package e2e

import (
"os"

awscloud "github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/cloud"
ebscsidriver "github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver"
"github.com/kubernetes-sigs/aws-ebs-csi-driver/tests/e2e/driver"
Expand Down Expand Up @@ -150,13 +148,9 @@ var _ = Describe("[ebs-csi-e2e] [single-az] [modify-volume] Modifying a PVC", fu
}
modifyVolumeTest.Run(cs, ns, ebsDriver, testsuites.VolumeModifierForK8s)
})
// HACK: Only run VAC tests if TEST_VAC is set - these tests are being skipped in CI because Kubernetes 1.31 is available
// This check can safely be removed after the single-az test is moved to Kubernetes 1.31 or later
if os.Getenv("TEST_VAC") != "" {
It("will modify associated PV and EBS Volume via external-resizer", func() {
modifyVolumeTest.Run(cs, ns, ebsDriver, testsuites.ExternalResizer)
})
}
It("will modify associated PV and EBS Volume via external-resizer", func() {
modifyVolumeTest.Run(cs, ns, ebsDriver, testsuites.ExternalResizer)
})
})
}
})

0 comments on commit ef505ff

Please sign in to comment.