Make hostNetwork configurable for daemonset

[bseenu]

Is this a bug fix or adding new feature?

bug fix

What is this PR about? / Why do we need it?

we want to run the daemonsets in host network, and want to make that configurable

What testing is done?

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: bseenu / name: Srinivas Boga (256d430, 3a4457e, b3aca02, 8d24b58)

[k8s-ci-robot]

Welcome @bseenu!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bseenu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[diranged]

Yes please - can we help get this pushed across the line?

[ConnorJC3]

/ok-to-test

[ConnorJC3]

Hi @bseenu - a few things:

First, is there a particular reason you want to run the driver in host network mode? This is a potentially footgun-ish feature, so I'm hesitant to expose it to users without a good reason.

Second, please remove the modifications to CHANGELOG.md and Chart.yaml. We generally do not accept PRs that add a feature and perform a release at the same time - releases are performed by our maintainers on a semi-regular schedule and take into account details such as backwards compatibility and support policies.

Third, you seem to have some minor test failures, please fix those (the Windows test is a known flake and is marked as optional, so you can ignore it, but the other test failures are likely legitimate).

[bseenu]

/retest

[diranged]

First, is there a particular reason you want to run the driver in host network mode? This is a potentially footgun-ish feature, so I'm hesitant to expose it to users without a good reason.

@ConnorJC3,
I would put this the other way around ... Is there a particular reason why we shouldn't be able to use hostNetwork: true here? This is following the pattern of the aws-efs-csi-driver https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/helm-chart-aws-efs-csi-driver-2.4.1/charts/aws-efs-csi-driver/templates/node-daemonset.yaml#L56. Sadly the aws-efs-csi-driver chart was updated without much explanation to remove this setting (kubernetes-sigs/aws-efs-csi-driver#910 (comment)) ... I have commented and am asking for clarity going forward.

Fundamentally DaemonSets not using hostNetwork have a few problems... not the least of which is the waste of IP space on large clusters (1000+ nodes). There are other issues like the fact that these pods can come up and fail if the CNI isn't ready yet (hint: IP/CIDR exhaustion), and that just causes more pods to be stuck in ContainerCreating for no good reason.

[jacobwolfaws]

First, is there a particular reason you want to run the driver in host network mode? This is a potentially footgun-ish feature, so I'm hesitant to expose it to users without a good reason.

@ConnorJC3, I would put this the other way around ... Is there a particular reason why we shouldn't be able to use hostNetwork: true here? This is following the pattern of the aws-efs-csi-driver https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/helm-chart-aws-efs-csi-driver-2.4.1/charts/aws-efs-csi-driver/templates/node-daemonset.yaml#L56. Sadly the aws-efs-csi-driver chart was updated without much explanation to remove this setting (kubernetes-sigs/aws-efs-csi-driver#910 (comment)) ... I have commented and am asking for clarity going forward.

Fundamentally DaemonSets not using hostNetwork have a few problems... not the least of which is the waste of IP space on large clusters (1000+ nodes). There are other issues like the fact that these pods can come up and fail if the CNI isn't ready yet (hint: IP/CIDR exhaustion), and that just causes more pods to be stuck in ContainerCreating for no good reason.

@diranged The reason why EFS (and FSx) removed hostNetwork: true from our repositories is that it exposes security risks to users. This link provides a good explanation for what those risks are.

In terms of the PR, I think if users want to configure hostNetwork: true they should be able to, just with the knowledge that doing so exposes their cluster to potential security risks.

[bseenu]

First, is there a particular reason you want to run the driver in host network mode? This is a potentially footgun-ish feature, so I'm hesitant to expose it to users without a good reason.

@ConnorJC3, I would put this the other way around ... Is there a particular reason why we shouldn't be able to use hostNetwork: true here? This is following the pattern of the aws-efs-csi-driver https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/helm-chart-aws-efs-csi-driver-2.4.1/charts/aws-efs-csi-driver/templates/node-daemonset.yaml#L56. Sadly the aws-efs-csi-driver chart was updated without much explanation to remove this setting (kubernetes-sigs/aws-efs-csi-driver#910 (comment)) ... I have commented and am asking for clarity going forward.
Fundamentally DaemonSets not using hostNetwork have a few problems... not the least of which is the waste of IP space on large clusters (1000+ nodes). There are other issues like the fact that these pods can come up and fail if the CNI isn't ready yet (hint: IP/CIDR exhaustion), and that just causes more pods to be stuck in ContainerCreating for no good reason.

@diranged The reason why EFS (and FSx) removed hostNetwork: true from our repositories is that it exposes security risks to users. This link provides a good explanation for what those risks are.

In terms of the PR, I think if users want to configure hostNetwork: true they should be able to, just with the knowledge that doing so exposes their cluster to potential security risks.

By default the chart would still be having it false, but makes that configurable whoever wants to change it

[bseenu]

Hi @bseenu - a few things:

First, is there a particular reason you want to run the driver in host network mode? This is a potentially footgun-ish feature, so I'm hesitant to expose it to users without a good reason.

Second, please remove the modifications to CHANGELOG.md and Chart.yaml. We generally do not accept PRs that add a feature and perform a release at the same time - releases are performed by our maintainers on a semi-regular schedule and take into account details such as backwards compatibility and support policies.

Third, you seem to have some minor test failures, please fix those (the Windows test is a known flake and is marked as optional, so you can ignore it, but the other test failures are likely legitimate).

removed the changes to changelog and chart.yaml, Thanks

[ConnorJC3]

We had some discussion about this and decided we're good with the change as long as it defaults to hostNetwork: false.

/lgtm
/cc @torredil @AndrewSirenko

[torredil]

/lgtm

[jacobwolfaws]

@bseenu can you squash the commits in this PR? It seems like they should all be in a single commit

[torredil]

/label tide/merge-method-squash

[ConnorJC3]

We can let prow squash it

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ConnorJC3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ConnorJC3]

/retest

[bseenu]

/retest