Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS #1737

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update OWNERS #1737

merged 1 commit into from
Sep 12, 2023

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
bugfix

What is this PR about? / Why do we need it?
Update OWNERS to include AndrewSirenko as reviewer and approver, as well as remove inactive reviewers.

What testing is done?
N/A

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
ConnorJC3
ConnorJC3 reviewed Sep 11, 2023
View reviewed changes
OWNERS Outdated Show resolved Hide resolved
OWNERS Outdated Show resolved Hide resolved
ConnorJC3
ConnorJC3 reviewed Sep 11, 2023
View reviewed changes
OWNERS Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 11, 2023
torredil
torredil approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorJC3
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 50c9228 into kubernetes-sigs:master Sep 12, 2023
4 checks passed
This was referenced Sep 25, 2023
Closed
Merged
@AndrewSirenko AndrewSirenko deleted the edit-owners branch November 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 ConnorJC3 left review comments

@torredil torredil torredil approved these changes

@gtxu gtxu Awaiting requested review from gtxu

Assignees

@ConnorJC3 ConnorJC3

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndrewSirenko @ConnorJC3 @k8s-ci-robot @torredil