Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume limits for m7a, c7i, r7a, r7iz instance families #1742

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add volume limits for m7a, c7i, r7a, r7iz instance families #1742

merged 1 commit into from
Sep 20, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Sep 15, 2023 •
edited
Loading

Is this a bug fix or adding new feature?

Updating hardcoded values.

What is this PR about? / Why do we need it?

This PR adds volume limits for m7a, c7i, r7a, and r7iz instance families. See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume_limits.html#nitro-system-limits.

What testing is done?

make test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@torredil torredil force-pushed the update-volume-limits branch from 698b6ab to 938a354 Compare September 15, 2023 11:01
AndrewSirenko
AndrewSirenko reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@ConnorJC3
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6d4ff98 into kubernetes-sigs:master Sep 20, 2023
4 checks passed
@torredil torredil mentioned this pull request Oct 16, 2023
Merged
@jsafrane jsafrane mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko AndrewSirenko left review comments

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torredil @ConnorJC3 @k8s-ci-robot @AndrewSirenko