Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static-provisioning example README.md #1755

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Sep 22, 2023

Is this a bug fix or adding new feature?
bug fix

What is this PR about? / Why do we need it?
Small documentation update for the static-provisioning example. Closes #1733.

What testing is done?
N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@ConnorJC3
Copy link
Contributor

/retest

@AndrewSirenko AndrewSirenko force-pushed the patch-2 branch 2 times, most recently from f52cd2f to 671f663 Compare September 25, 2023 15:25
@ConnorJC3 ConnorJC3 force-pushed the patch-2 branch 2 times, most recently from 518ac63 to 83861f0 Compare September 25, 2023 17:54
Co-authored-by: Drew Sirenko <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2023
@AndrewSirenko
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@AndrewSirenko: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AndrewSirenko
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit e488c7b into kubernetes-sigs:master Sep 25, 2023
4 checks passed
@AndrewSirenko AndrewSirenko deleted the patch-2 branch November 1, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add line in README.md for static provisioning ebs
4 participants