[Hold] Add format option e2e tests #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
AndrewSirenko
commented
Sep 28, 2023
| Context(fmt.Sprintf("with an %s filesystem", fsType), func() { | ||
| // TODO: is t clear? Or should it be 'formatOptionTestCaseValues' | ||
| for _, t := range formatOptionTests { | ||
| if fsTypeDoesNotSupportFormatOptionParameter(fsType, t.createVolumeParameterKey) { |
There was a problem hiding this comment.
Can move to inside spec itself with ginkgo.Skip() to be slightly cleaner!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Incomplete PR for adding format option e2e tests. They test that a volume created with a supported custom format option successfully mount and are later resizable.
Considering refactoring part of format_options.go into a tester file like other e2e tests.
See individual commits for conceptual breakdown.
For this PR I'm looking for feedback on:
What testing is done?
ginkgo run -v --focus='[format-options'