Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume attachment limits for c7a instance family #1776

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add volume attachment limits for c7a instance family #1776

merged 1 commit into from
Oct 6, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented Oct 6, 2023

What is this PR about? / Why do we need it?

Add volume attachment limits for c7a instance family, see https://aws.amazon.com/about-aws/whats-new/2023/10/compute-optimized-amazon-ec2-c7a-instances/.

What testing is done?

make test

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2023
@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2023
@ConnorJC3
Copy link
Contributor

/honk

@k8s-ci-robot
Copy link
Contributor

@ConnorJC3:
goose image

In response to this:

/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Code Coverage Diff

This PR does not change the code coverage

@rdpsin
Copy link
Contributor

rdpsin commented Oct 6, 2023

/lgtm but we really should find a better way than hardcoding these values. (mea culpa, since I wrote the first version).

@AndrewSirenko
Copy link
Contributor

/retest

@AndrewSirenko
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e2a9600 into kubernetes-sigs:master Oct 6, 2023
6 checks passed
@torredil torredil mentioned this pull request Oct 16, 2023
Merged
@jsafrane jsafrane mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko Awaiting requested review from AndrewSirenko

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torredil @ConnorJC3 @k8s-ci-robot @rdpsin @AndrewSirenko