fix: Add parameters for tuning revisionHistoryLimit and emptyDir volumes

[bodgit]

Is this a bug fix or adding new feature?

Helm chart feature.

What is this PR about? / Why do we need it?

This PR adds chart parameters to tune the revisionHistoryLimit on the Deployment & DaemonSet and also to tune the emptyDir volumes used for sockets and probes, (set sizeLimit, medium, etc.).

Default values match the implicit Kubernetes default (in the case of revisionHistoryLimit) or match the original hardcoded value.

What testing is done?

Generated manifests only show the addition of the (now explicit) default revisionHistoryLimit, volumes remain unchanged.

[k8s-ci-robot]

Welcome @bodgit!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bodgit. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AndrewSirenko]

/ok-to-test

[bodgit]

/retest

[bodgit]

I'm not sure why this test is failing. Any ideas?

[torredil]

@bodgit See details here #1858 (comment). The failure is not related to this PR.

[AndrewSirenko]

/retest

[AndrewSirenko]

/retest

[bodgit]

I still don't understand why this test is failing. The pertinent error seems to be:

Error: UPGRADE FAILED: YAML parse error on aws-ebs-csi-driver/templates/controller.yaml: error converting YAML to JSON: yaml: line 268: could not find expected ':'

but it's not obvious what that YAML looks like. If I render the controller.yaml manually with default values, it's not even 268 lines long.

I can't see where the tests are defined to try and pick through those.

[bodgit]

Is this #1864 by any chance?

[bodgit]

Adding some logic guards to ensure the new parameters are set seems to have fixed this, indeed related to #1864.

Ping @AndrewSirenko @torredil

[github-actions]

Code Coverage Diff

File	Old Coverage	New Coverage	Delta
github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/controller.go	83.5%	83.8%	0.3

[AndrewSirenko]

Thank you for contribution (and the fix @bodgit), it looks good to me, will let @torredil or @ConnorJC3 approve.

[ConnorJC3]

/lgtm

[torredil]

Thanks @bodgit
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment