Ignore mocks in code coverage report #1851
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
Currently our code coverage tool's per-package code-coverage is inaccurate due to our mock files being tracked by
go test -coverprofile
.By appending
_test
to each mock file,go test
will know that these files should not be counted towards the code-coverage score.What testing is done?
make mockgen
succeedsNOTE:
make verify
fails when verifyinggovet
with the following error:But these files should be handled by
make mockgen