Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about --reuse-values to NOTES.txt #1865

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add warning about --reuse-values to NOTES.txt #1865

merged 1 commit into from
Dec 14, 2023

Conversation

ConnorJC3
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

torredil
torredil approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@torredil
Copy link
Member

/retest

17 similar comments
@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@torredil
Copy link
Member

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@ConnorJC3
Copy link
Contributor Author

/retest

@torredil
Copy link
Member

One final time:
/lgtm

@torredil
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
AndrewSirenko
AndrewSirenko approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great warning, thank you.

@k8s-ci-robot k8s-ci-robot merged commit 1e9f815 into kubernetes-sigs:master Dec 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ConnorJC3 @torredil @k8s-ci-robot @AndrewSirenko