Add ext3 and xfs fsTypes to e2e format-option test coverage #1890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Test coverage
What is this PR about? / Why do we need it?
Adds
ebscsidriver.FSTypeExt3
andebscsidriver.FSTypeXfs
as tested filesystems for our e2e format option tests.This is separate from turning on the
ext3
feature flag for upstream k8s storage conformance tests. See #1891 for that.This is separate from the discussion of whether we are deprecating support for
ext2
This would add the following tests:
(Note, not all formatting-option parameters that are supported for ext4 are supported for ext3 and xfs. See pkg/driver/constants.go)
What testing is done?
Manually running the new ext3 and xfs format option tests. Here is a list of those tests.