Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext3 and xfs fsTypes to e2e format-option test coverage #1890

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Jan 10, 2024

Is this a bug fix or adding new feature?
Test coverage

What is this PR about? / Why do we need it?
Adds ebscsidriver.FSTypeExt3 and ebscsidriver.FSTypeXfs as tested filesystems for our e2e format option tests.

This is separate from turning on the ext3 feature flag for upstream k8s storage conformance tests. See #1891 for that.

This is separate from the discussion of whether we are deprecating support for ext2

This would add the following tests:

[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom blocksize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom bytesperinode parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom inodesize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom numberofinodes parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an xfs filesystem with a custom blocksize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an xfs filesystem with a custom inodesize parameter successfully mounts and is resizable

(Note, not all formatting-option parameters that are supported for ext4 are supported for ext3 and xfs. See pkg/driver/constants.go)

What testing is done?
Manually running the new ext3 and xfs format option tests. Here is a list of those tests.

❯ ginkgo run --focus 'format-options' --dry-run -v | grep -i "az"
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom blocksize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom bytesperinode parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom inodesize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext3 filesystem with a custom numberofinodes parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom blocksize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom bytesperinode parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom ext4bigalloc parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom ext4clustersize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom inodesize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an ext4 filesystem with a custom numberofinodes parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an xfs filesystem with a custom blocksize parameter successfully mounts and is resizable
[ebs-csi-e2e] [single-az] [format-options] Formatting a volume using an xfs filesystem with a custom inodesize parameter successfully mounts and is resizable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5706bd9 into kubernetes-sigs:master Jan 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants