-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Trivy image scanner #1912
Fix Trivy image scanner #1912
Conversation
ede6c09
to
5034579
Compare
Code Coverage DiffThis PR does not change the code coverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch on non-authenticated rate limits being different, and thanks for version bump.
Signed-off-by: Eddie Torres <[email protected]>
5034579
to
27819ad
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is this PR about? / Why do we need it?
This PR addresses a recurring issue with the Trivy image scanner action:
More specifically, this PR fixes errors during image pulls due to unauthenticated rate limits and adds an explicit step to pull the container images before initiating the Trivy scan.
See the logs
What testing is done?
Manual