Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate KubeLinter recommended best practices for chart tester pod #1924

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Incorporate KubeLinter recommended best practices for chart tester pod #1924

merged 1 commit into from
Feb 13, 2024

Conversation

torredil
Copy link
Member

@torredil torredil commented Feb 6, 2024

What is this PR about? / Why do we need it?

Complementary PR to #1923, see #1923 (comment) for context.

What testing is done?

$ kube-linter lint aws-ebs-csi-driver 
KubeLinter development

No lint errors found!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Code Coverage Diff

This PR does not change the code coverage

@torredil torredil force-pushed the kube-linter-fix branch 2 times, most recently from fa75f16 to 6c1a261 Compare February 6, 2024 20:13
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@torredil torredil force-pushed the kube-linter-fix branch 2 times, most recently from 7c2d328 to b065b94 Compare February 6, 2024 20:17
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@rdpsin
Copy link
Contributor

rdpsin commented Feb 9, 2024

Should kubelinter be a CI job as well?

@torredil
Copy link
Member Author

torredil commented Feb 9, 2024

@rdpsin Worth evaluating, especially as a non-required CI job. I'll add a task for it.

@torredil
Copy link
Member Author

/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

@torredil
Copy link
Member Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@torredil
Copy link
Member Author

/test pull-aws-ebs-csi-driver-test-helm-chart

@torredil torredil requested a review from ConnorJC3 February 12, 2024 15:24
AndrewSirenko
AndrewSirenko approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement. One less cx papercut.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@torredil
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@torredil
Copy link
Member Author

/test pull-aws-ebs-csi-driver-unit

@k8s-ci-robot k8s-ci-robot merged commit a894a85 into kubernetes-sigs:master Feb 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorJC3 ConnorJC3 Awaiting requested review from ConnorJC3

@AndrewSirenko AndrewSirenko Awaiting requested review from AndrewSirenko

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@torredil @k8s-ci-robot @rdpsin @ConnorJC3 @AndrewSirenko