Fix Three Papercuts #1933
Merged
Fix Three Papercuts #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s invalid Signed-off-by: Connor Catlett <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
Code Coverage DiffThis PR does not change the code coverage |
|
/retest |
Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
AndrewSirenko
approved these changes
Feb 14, 2024
k8s-ci-robot
added
the
lgtm
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix
What is this PR about? / Why do we need it?
Fixes three small papercuts (each in their own commit):
Fix kops clusters becoming stuck when local KUBECONFIG is invalid
When the local kubeconfig represents a cluster that no longer exists, patching (and thus creating) a kops-based cluster will get stuck. This fixes that by explcitly setting the config for patch operations to
/dev/nullRestrain
shfmttohack/directoryshfmtwas trying to modify scripts in thevenvinbin/, sometimes causingmake verify/updateto fail locally.Attempt to delete Prow clusters that fail to create
We already delete clusters where the e2e tests fail (as of #1856), but leave behind clusters where creation failed.
What testing is done?
Manual/CI