Add OS topology key to node segments map

[torredil]

What is this PR about? / Why do we need it?

This PR introduces the addition of an (OS) topology key to the node segments map returned by NodeGetInfo within the node service.

The change enables scoping down a StorageClass using the allowedTopologies attribute to an OS type. It is backward compatible and should not impact existing deployments. Nodes will simply start reporting additional topology information post-update.

Fixes #1946

What testing is done?

make test && manual testing && CI e2e

Example StorageClass:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
allowedTopologies:
- matchLabelExpressions:
  - key: kubernetes.io/os
    values:
    - windows
  - key: topology.ebs.csi.aws.com/zone
    values:
    - us-east-2c

Without this patch:

  Warning  ProvisioningFailed    4s (x4 over 11s)  ebs.csi.aws.com_ebs-csi-controller-56bfc45bc5-5ckcz_d0df82a6-2e08-4622-b0ec-dbe4927673e0  failed to provision volume with StorageClass "ebs-sc": error generating accessibility requirements: topology map[topology.ebs.csi.aws.com/zone:us-east-2c topology.kubernetes.io/zone:us-east-2c] from selected node "ip-192-168-28-75.us-east-2.compute.internal" is not in requisite: [map[kubernetes.io/os:linux topology.ebs.csi.aws.com/zone:us-east-2c]]

With this patch:

  Normal   ProvisioningSucceeded  17s                ebs.csi.aws.com_ebs-csi-controller-7bf457699-8b7gk_ead7e79a-c4ee-4ad9-a66e-bf02e146c62b   Successfully provisioned volume pvc-8f101bfd-d76a-45a7-88d3-05091814375c

[github-actions]

Code Coverage Diff

This PR does not change the code coverage

[AndrewSirenko]

Thanks for this paper-cut alleviation!

[ConnorJC3]

/lgtm

Agree on renaming TopologyKey/WellKnownTopologyKey, would recommend name of ZoneTopologyKey over AZ, as "zone" is the terminology generally used by upstream k8s.

[ConnorJC3]

/lgtm

(might need gofmt pass?)

[torredil]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment