Randomly generate tag names in e2e tests to prevent flakes due to collisions #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
Code Coverage DiffThis PR does not change the code coverage |
AndrewSirenko
changed the title
AndrewSirenko
force-pushed
the
fix-tag-test
branch
2 times, most recently
from
52c159d to
0489ce9
Compare
ConnorJC3
reviewed
Mar 14, 2024
k8s-ci-robot
added
the
lgtm
AndrewSirenko
force-pushed
the
fix-tag-test
branch
from
0489ce9 to
836e494
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
AndrewSirenko
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
AndrewSirenko
force-pushed
the
fix-tag-test
branch
from
836e494 to
a2d834c
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Bug fix e2e
What is this PR about? / Why do we need it?
Today we use a fixed tag name in our AWS volume and snapshot tagging single-az e2e tests. This may lead to collisions when multiple tests are done in parallel and/or test resources are not cleaned up properly (e.g. a test is aborted).
This should unblock CI, which is suffering from this problem.
What testing is done?
CI