Fixup Helm test job #1978
Merged
Fixup Helm test job #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
ConnorJC3
force-pushed
the
fix-helm-test
branch
from
7dd6215 to
88e0b79
Compare
Code Coverage DiffThis PR does not change the code coverage |
ConnorJC3
force-pushed
the
fix-helm-test
branch
2 times, most recently
from
42bd739 to
ccccd8d
Compare
1. Fixes quoting issues in Helm test pod causing disruptive tests to run (also cleans up the logic a bit to greatly increase readability) 2. Bumps kubekins image to latest tag 3. Removes `--reuse-values` workaround that is no longer needed 4. Add memory limit to tester pod, bump requests 5. Bump instance type to `c5.xlarge` for helm CI job Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
fix-helm-test
branch
from
ccccd8d to
c1fef6f
Compare
k8s-ci-robot
added
the
lgtm
AndrewSirenko
approved these changes
Mar 21, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
"Bug fix" for CI
What is this PR about? / Why do we need it?
--reuse-valuesworkaround that is no longer neededc5.xlargefor helm CI jobWhat testing is done?
CI