Improve configuration management; Improve the relationship between driver, controller, & cloud #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
Code Coverage Diff
|
|
/retest |
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
5ea046f to
f1cfddd
Compare
k8s-ci-robot
added
size/XXL
torredil
changed the title
|
Nit: let's separate CVE fix from rest of PR. See Fix CVE G0-2024-2687 by bumping go and /x/net dependencies |
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
7391ee0 to
f1cfddd
Compare
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
f1cfddd to
c249057
Compare
|
CI is down: |
|
/retest |
|
CI has been restored |
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
4497e74 to
a654703
Compare
AndrewSirenko
approved these changes
Apr 11, 2024
k8s-ci-robot
added
the
lgtm
ConnorJC3
reviewed
Apr 12, 2024
|
Side note: Will need rebase on top of #2007 after it is merged |
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
a654703 to
e6c731a
Compare
k8s-ci-robot
removed
the
lgtm
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
e6c731a to
a32b96b
Compare
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
a32b96b to
5caa059
Compare
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
/retest |
1 similar comment
|
/retest |
…iver, controller, & cloud Signed-off-by: torredil <[email protected]>
torredil
force-pushed
the
csi-refactor-cloud-metadata
branch
from
5caa059 to
42fc084
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
This patch is the first of two, designed to improve the architecture of the code base with the goal of promoting a more cohesive and understandable design that makes it easier to reason about the driver and make future modifications or extensions more intuitive.
More specifically, this PR improves driver configuration management, migrates the metadata service into its own separate package to encapsulate metadata related functionality, and improves the relationship between driver/controller and cloud by separating the creation of
ControllerServicefrom its usage.Summary of Changes
Fix relationship between cmd/main and pkg/driver
Optionsstruct has been moved to the driver package, consolidating all driver-related configuration options in one place.cmdpackage now focuses solely on the main entry point and setting up the necessary dependencies.NewDriverfunction now accepts a pointer toOptionsinstead of a variadic function, making it clearer and more straightforward to create a new driver instance.Migrate metadata service
metadata_ec2.go,metadata.go,metadata_interface.go,metadata_k8s.go,metadata_test.go, andmock_metadata.go) from the cloud package to a new metadata package.Improve relationship between driver and cloud
newControllerServicewithNewControllerService, which now takes a cloud object and options as parameters, allowing for dependency injection and easier testing.NewMetadataFuncandNewCloudFuncvariables as they are no longer needed with the new architecture.main.gofile to create an instance of cloud to pass intoNewDriver.ControllerService.Note to Reviewer
This PR intentionally disables
csi-sanitytests temporarily now thatNewFakeDriverfunc which was previously created to instantiate a fake driver utilized in the sanity tests has been removed. These sanity tests must be re-written.What testing is done?
make verify && make test