-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add requirements.in files with fixed versions to use in pip #2012
Conversation
|
Welcome @echyam! |
Hi @echyam. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@echyam thank you for your PR, but I believe you need to sign the CLA See this comment: #2012 (comment) |
/ok-to-test Thanks for signing the CLA, will try to get this reviewed next week |
Code Coverage Diff
|
@ConnorJC3 any chance of update this week? |
Sorry, got busy last week /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this best-practice.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind cleanup
Is this a bug fix or adding new feature?
Makes pip install install fixed versions with a
xxx-requirements.in
file per package (aws, yamale, yamllint)What is this PR about? / Why do we need it?
Verifies pip packages being installed with hashes.
What testing is done?
Tested installing the affected packages via the modified script and able to successfully use them.
Successfully ran
make verify
,make test
.make test-integration
not available.