Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GO-2024-2824 #2038

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

torredil
Copy link
Member

Is this a bug fix or adding new feature?

CVE Fix

What is this PR about? / Why do we need it?

Vulnerability #1: GO-2024-2824
    Malformed DNS message can cause infinite loop in net
  More info: https://pkg.go.dev/vuln/GO-2024-2824
  Standard library
    Found in: [email protected]
    Fixed in: [email protected]
    Example traces found:
Error:       #1: tests/e2e/testsuites/testsuites.go:752:78: testsuites.podLogs calls rest.Request.Do, which eventually calls net.Dialer.DialContext
Error:       #2: pkg/driver/driver.go:99:29: driver.Driver.Run calls net.Listen
Error:       #3: pkg/cloud/cloud.go:331:38: cloud.newEC2Cloud calls config.LoadDefaultConfig, which eventually calls net.LookupHost
Error:       #4: tests/e2e/format_options.go:33:17: e2e.init calls ginkgo.Describe, which eventually calls net.Resolver.LookupHost
Error:       #5: tests/e2e/format_options.go:33:17: e2e.init calls ginkgo.Describe, which eventually calls net.Resolver.LookupSRV
Error:       #6: tests/e2e/format_options.go:33:17: e2e.init calls ginkgo.Describe, which eventually calls net.Resolver.LookupTXT

What testing is done?

make verify && make test

Signed-off-by: torredil <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ConnorJC3
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@AndrewSirenko
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@AndrewSirenko
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 988daff into kubernetes-sigs:master May 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants