Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for PodDisruptionBudget in chart #2109

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?

/feature

What is this PR about? / Why do we need it?

Fixes #1934

The EBS CSI Controller Pod's PodDisruptionBudget ensures that 1 controller Pod is always running, even when many nodes are being drained at once. This ensures that PersistentVolumes are always able to be Attached/Detached Created/Deleted, and that stateful pods are not delayed by missing PVs.

Some customers have requested ability to disable this PodDisruptionBudget in order to prioritize node draining / Karpenter consolidation over the availability of the EBS CSI Driver. While we don't recommend this, this PR exposes the parameter for those who use EBS only with non-critical applications.

**What testing is

See the following rendered helm templates with and without --set controller.podDisruptionBudget=false, along with the diff

change.txt
default.txt
diff.txt
done?**

Diff:

2,22d1
< # Source: aws-ebs-csi-driver/templates/poddisruptionbudget-controller.yaml
< apiVersion: policy/v1
< kind: PodDisruptionBudget
< metadata:
<   name: ebs-csi-controller
<   namespace: default
<   labels:
<     app.kubernetes.io/name: aws-ebs-csi-driver
<     app.kubernetes.io/instance: release-name
<     helm.sh/chart: aws-ebs-csi-driver-2.33.0
<     app.kubernetes.io/version: "1.33.0"
<     app.kubernetes.io/component: csi-driver
<     app.kubernetes.io/managed-by: Helm
< spec:
<   selector:
<     matchLabels:
<       app: ebs-csi-controller
<       app.kubernetes.io/name: aws-ebs-csi-driver
<       app.kubernetes.io/instance: release-name
<   maxUnavailable: 1
< ---

Proof in deployed cluster:

❯ helm upgrade \
  --install aws-ebs-csi-driver \
  ... 
  --set controller.podDisruptionBudget=false

❯ kubectl get pdb -A
NAMESPACE     NAME                           MIN AVAILABLE   MAX UNAVAILABLE   ALLOWED DISRUPTIONS   AGE
kube-system   aws-node-termination-handler   N/A             1                 1                     105m
kube-system   cilium-operator                N/A             1                 1                     105m
kube-system   kube-dns                       N/A             50%               1                     105m

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones
Copy link
Member

/retest

@torredil
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 13, 2024
@AndrewSirenko
Copy link
Contributor Author

/hold

Wait for #2106 to merge first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2024
@torredil
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@AndrewSirenko
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit bdcd2e9 into kubernetes-sigs:master Aug 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable PDB for managed addon
5 participants