-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle for PodDisruptionBudget in chart #2109
Conversation
Code Coverage DiffThis PR does not change the code coverage |
/retest |
/lgtm |
b63e92f
to
f72f915
Compare
/hold Wait for #2106 to merge first |
f72f915
to
1a2278f
Compare
1a2278f
to
7132555
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Is this a bug fix or adding new feature?
/feature
What is this PR about? / Why do we need it?
Fixes #1934
The EBS CSI Controller Pod's PodDisruptionBudget ensures that 1 controller Pod is always running, even when many nodes are being drained at once. This ensures that PersistentVolumes are always able to be Attached/Detached Created/Deleted, and that stateful pods are not delayed by missing PVs.
Some customers have requested ability to disable this PodDisruptionBudget in order to prioritize node draining / Karpenter consolidation over the availability of the EBS CSI Driver. While we don't recommend this, this PR exposes the parameter for those who use EBS only with non-critical applications.
**What testing is
See the following rendered helm templates with and without
--set controller.podDisruptionBudget=false
, along with the diffchange.txt
default.txt
diff.txt
done?**
Diff:
Proof in deployed cluster: