Automatically update RBAC in make update-sidecar-dependencies
#2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
ConnorJC3
force-pushed
the
autopull-rbac
branch
from
5de10de to
b12cf61
Compare
Code Coverage DiffThis PR does not change the code coverage |
ConnorJC3
force-pushed
the
autopull-rbac
branch
4 times, most recently
from
cb79e8c to
54d692b
Compare
ConnorJC3
changed the title
make update-sidecar-dependenciesmake update-sidecar-dependencies
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Connor Catlett <[email protected]>
ConnorJC3
force-pushed
the
autopull-rbac
branch
from
54d692b to
b1c0226
Compare
AndrewSirenko
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Worked for me on MacOS, even with manually deleting a couple of the apiGroups in a couple of sidecar RBAC templates. Thanks @ConnorJC3!
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
New feature for devs
What is this PR about? / Why do we need it?
Automates updating the sidecar RBAC perms from upstream in
make update-sidecar-dependencies. This will slightly speed up releases and greatly reduce the chance of error.I have manually run the script through to seed the files. Beyond shuffling the values and adding some missing permissions, it removed the following permissions:
What testing is done?
Manually tested, CI