Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K8s 1.31 to CI by pinning kops commit instead of version #2160

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

AndrewSirenko
Copy link
Contributor

@AndrewSirenko AndrewSirenko commented Sep 27, 2024

Is this a bug fix or adding new feature?
CI

What is this PR about? / Why do we need it?

This PR should not be merged until we fix any rate-limit issues in our CI (likely by submitting a PR to kops for different retry policies)

We want our CI to test changes to the EBS CSI Driver against the latest stable version of Kubernetes to proactively spot issues and guarantee that we pass the Kubernetes Storage conformance tests.

However, EKS and recently kOps do not release support for the latest stable Kubernetes version until 1-2 months afterwards, which blocks us from upgrading our CI to the latest Kubernetes version.

Many of upstream e2e tests run against newer versions of Kubernetes without the latest kops version (see test-infra jobs). This is because there are usually a few unreleased fixes on the main branch that allow kops to be used for newer Kubernetes versions when combined with exporting KOPS_RUN_TOO_NEW_VERSION=true. This PR pins our CI to a Kops commit instead of a release so that we can do the same with our custom cluster testing system.

What testing is done?

Local + CI

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2024
Copy link

Code Coverage Diff

This PR does not change the code coverage

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
@AndrewSirenko
Copy link
Contributor Author

/retest

/ok-to-test

/test pull-aws-ebs-csi-driver-e2e-single-az

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 1, 2024
@AndrewSirenko AndrewSirenko reopened this Oct 2, 2024
@AndrewSirenko AndrewSirenko marked this pull request as ready for review October 2, 2024 16:48
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@AndrewSirenko AndrewSirenko changed the title Add K8s 1.31 to CI by pinning kops commit instead of version wip: Add K8s 1.31 to CI by pinning kops commit instead of version Oct 2, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@AndrewSirenko AndrewSirenko marked this pull request as draft October 2, 2024 19:26
@AndrewSirenko
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@AndrewSirenko AndrewSirenko marked this pull request as ready for review October 2, 2024 20:19
@AndrewSirenko AndrewSirenko marked this pull request as draft October 2, 2024 21:00
@AndrewSirenko AndrewSirenko marked this pull request as ready for review October 2, 2024 21:04
@AndrewSirenko AndrewSirenko marked this pull request as draft October 2, 2024 21:13
@AndrewSirenko
Copy link
Contributor Author

/retest

Seems like e2e flake, NOT cluster up flake:

  [FAIL] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)] fsgroupchangepolicy [It] (OnRootMismatch)[LinuxOnly], pod created with an initial fsgroup, new pod fsgroup applied to volume contents

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@AndrewSirenko AndrewSirenko force-pushed the kops-k8s-131 branch 3 times, most recently from a8e2811 to f531748 Compare October 15, 2024 20:36
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
@torredil
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2024
@AndrewSirenko
Copy link
Contributor Author

/retest

Windows e2e flake unrelated to kops


Kubernetes e2e suite: [It] External Storage [Driver: ebs.csi.aws.com] [Testpattern: Dynamic PV (default fs)(allowExpansion)] volume-expand Verify if offline PVC expansion works expand_more
--

I've seen this flake a few times in the past two weeks. making backlog item to look into it.

@k8s-ci-robot k8s-ci-robot merged commit ea90143 into kubernetes-sigs:master Oct 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants