-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add K8s 1.31 to CI by pinning kops commit instead of version #2160
Add K8s 1.31 to CI by pinning kops commit instead of version #2160
Conversation
Skipping CI for Draft Pull Request. |
Code Coverage DiffThis PR does not change the code coverage |
ac8bc2f
to
59cbbdc
Compare
/retest /ok-to-test /test pull-aws-ebs-csi-driver-e2e-single-az |
59cbbdc
to
3b45ea9
Compare
/test pull-aws-ebs-csi-driver-e2e-single-az |
3b45ea9
to
42b92c2
Compare
42b92c2
to
138e59b
Compare
138e59b
to
9af6227
Compare
/retest Seems like e2e flake, NOT cluster up flake:
|
bce4195
to
3c2acbf
Compare
3c2acbf
to
a8a66a8
Compare
a8e2811
to
f531748
Compare
f531748
to
dc410fa
Compare
dc410fa
to
d1d1932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Windows e2e flake unrelated to kops
I've seen this flake a few times in the past two weeks. making backlog item to look into it. |
Is this a bug fix or adding new feature?
CI
What is this PR about? / Why do we need it?
This PR should not be merged until we fix any rate-limit issues in our CI (likely by submitting a PR to kops for different retry policies)
We want our CI to test changes to the EBS CSI Driver against the latest stable version of Kubernetes to proactively spot issues and guarantee that we pass the Kubernetes Storage conformance tests.
However, EKS and recently kOps do not release support for the latest stable Kubernetes version until 1-2 months afterwards, which blocks us from upgrading our CI to the latest Kubernetes version.
Many of upstream e2e tests run against newer versions of Kubernetes without the latest kops version (see test-infra jobs). This is because there are usually a few unreleased fixes on the main branch that allow kops to be used for newer Kubernetes versions when combined with exporting
KOPS_RUN_TOO_NEW_VERSION=true
. This PR pins our CI to a Kops commit instead of a release so that we can do the same with our custom cluster testing system.What testing is done?
Local + CI