Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FAQ to include section on Volume Attachment Capacity Issues #2169

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update FAQ to include section on Volume Attachment Capacity Issues #2169

merged 1 commit into from
Oct 7, 2024

Conversation

torredil
Copy link
Member

@torredil torredil commented Oct 4, 2024

Is this a bug fix or adding new feature?

Documentation

What is this PR about? / Why do we need it?

See #2153 for context.

@k8s-ci-robot k8s-ci-robot requested a review from ConnorJC3 October 4, 2024 20:19
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Code Coverage Diff

This PR does not change the code coverage

ElijahQuinones
ElijahQuinones reviewed Oct 4, 2024
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
ElijahQuinones
ElijahQuinones approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thank you for keeping the docs up to date 😃

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@rdpsin
Copy link
Contributor

rdpsin commented Oct 4, 2024

This is super nitpicky but seeing that this is turning out to be a dense document (which is good!), does it make sense to add a table of contents on top?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2024
@torredil
Copy link
Member Author

torredil commented Oct 4, 2024

@rdpsin Great suggestion! added a ToC : )

@ElijahQuinones
Copy link
Member

/lgtm tested all the links in table of contents all work perfectly.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
AndrewSirenko
AndrewSirenko reviewed Oct 7, 2024
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
AndrewSirenko
AndrewSirenko approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean, thank you!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@ElijahQuinones
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
ConnorJC3
ConnorJC3 reviewed Oct 7, 2024
View reviewed changes
docs/faq.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 7, 2024
ConnorJC3
ConnorJC3 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@torredil
Copy link
Member Author

torredil commented Oct 7, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 515151b into kubernetes-sigs:master Oct 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElijahQuinones ElijahQuinones ElijahQuinones approved these changes

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@ConnorJC3 ConnorJC3 ConnorJC3 approved these changes

Assignees

@ConnorJC3 ConnorJC3

@AndrewSirenko AndrewSirenko

@ElijahQuinones ElijahQuinones

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@torredil @rdpsin @ElijahQuinones @k8s-ci-robot @ConnorJC3 @AndrewSirenko