Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate image dependency upgrades & Migrate to kubekins-e2e-v2 #2177

Merged

Conversation

AndrewSirenko
Copy link
Contributor

Is this a bug fix or adding new feature?
Automation

What is this PR about? / Why do we need it?

First, this PR automates two manual steps of our release process: updating the kubekins e2e image in our Helm chart, and updating the gcb-docker-gcloud image in our cloudbuild.yaml.

It combines these updates with our sidecar update script in the new Makefile target: update-image-dependencies


Second, kubekins-e2e is deprecated, so let's move to kubekins-e2e-v2

Quote from Kubernetes SIG-Testing slack:

  • It is leaner than the old image. We got rid of many legacy CI deps/tooling that are specific to k/k and don't need to be used in most repos
  • It is a multiarch image, amd64 and arm64. This is important as we'll be running arm64 nodes in Prow in the future and someone recently proposed dynamic scheduling in Prow so if it works out, we would benefit from having many cloud and architecture agnostic jobs.
  • It is built directly from debian:bookworm instead of bootstrap(a sig-testing image built from debian with legacy CI deps).

Will update internal runbook after merge.

What testing is done?

./hack/release-scripts/update-e2e-images works!
make update-image-dependencies works!

Lets hope CI is a fan of kubekins-e2e-v2...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Code Coverage Diff

This PR does not change the code coverage

@ElijahQuinones ElijahQuinones self-assigned this Oct 9, 2024
Copy link
Member

@ElijahQuinones ElijahQuinones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./hack/release-scripts/update-e2e-images
2024-10-09 21:26:29 [INFO] - Fetching latest kubekins-e2e-v2 image from us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e
2024-10-09 21:26:30 [INFO] - Updating kubekins-e2e-v2 image in /local/home/elijahlq/aws-ebs-csi-driver/hack/release-scripts/../../charts/aws-ebs-csi-driver/values.yaml to us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e:v20240903-6a352c5344-master
2024-10-09 21:26:30 [INFO] - Fetching latest gcb-docker-gcloud image from gcr.io/k8s-staging-test-infra/gcb-docker-gcloud
2024-10-09 21:26:30 [INFO] - Updating gcb-docker-gcloud image in /local/home/elijahlq/aws-ebs-csi-driver/hack/release-scripts/../../cloudbuild.yaml to gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36
2024-10-09 21:26:30 [INFO] - Success! Updated kubekins-e2e-v2 and gcb-docker-gcloud images!

Thank you !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One np, otherwise lgtm

hack/release-scripts/update-e2e-images Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2024
@AndrewSirenko
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 11, 2024
Copy link
Contributor

@ConnorJC3 ConnorJC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorJC3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 38f0b20 into kubernetes-sigs:master Oct 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants