-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate image dependency upgrades & Migrate to kubekins-e2e-v2 #2177
Automate image dependency upgrades & Migrate to kubekins-e2e-v2 #2177
Conversation
Code Coverage DiffThis PR does not change the code coverage |
4fc1663
to
ffcba30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./hack/release-scripts/update-e2e-images
2024-10-09 21:26:29 [INFO] - Fetching latest kubekins-e2e-v2 image from us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e
2024-10-09 21:26:30 [INFO] - Updating kubekins-e2e-v2 image in /local/home/elijahlq/aws-ebs-csi-driver/hack/release-scripts/../../charts/aws-ebs-csi-driver/values.yaml to us-central1-docker.pkg.dev/k8s-staging-test-infra/images/kubekins-e2e:v20240903-6a352c5344-master
2024-10-09 21:26:30 [INFO] - Fetching latest gcb-docker-gcloud image from gcr.io/k8s-staging-test-infra/gcb-docker-gcloud
2024-10-09 21:26:30 [INFO] - Updating gcb-docker-gcloud image in /local/home/elijahlq/aws-ebs-csi-driver/hack/release-scripts/../../cloudbuild.yaml to gcr.io/k8s-staging-test-infra/gcb-docker-gcloud:v20240718-5ef92b5c36
2024-10-09 21:26:30 [INFO] - Success! Updated kubekins-e2e-v2 and gcb-docker-gcloud images!
Thank you !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One np, otherwise lgtm
Co-authored-by: ConnorJC <[email protected]>
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorJC3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature?
Automation
What is this PR about? / Why do we need it?
First, this PR automates two manual steps of our release process: updating the kubekins e2e image in our Helm chart, and updating the gcb-docker-gcloud image in our cloudbuild.yaml.
It combines these updates with our sidecar update script in the new Makefile target:
update-image-dependencies
Second, kubekins-e2e is deprecated, so let's move to kubekins-e2e-v2
Quote from Kubernetes SIG-Testing slack:
Will update internal runbook after merge.
What testing is done?
./hack/release-scripts/update-e2e-images
works!make update-image-dependencies
works!Lets hope CI is a fan of kubekins-e2e-v2...