-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example-iam-policy.json #2193
Conversation
wildcard the aws partion field to prevent exclusion of partitions other than `aws`
Welcome @willswire! |
Hi @willswire. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Thank you for this @willswire! Any contribution, even non-code changes, requires #2189 (comment), but we will merge this in right afterwards. |
Code Coverage DiffThis PR does not change the code coverage |
No problem - completed! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wildcard the aws partion field to prevent exclusion of partitions other than
aws
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
we noticed that a similar change on the Terraform modules for AWS broke IaC deploys for partitions other than
aws
(likeaws-us-gov
for example)What testing is done?